[L2Ork-dev] Current HEAD of Purr Data is broken

[Albert Graef]

Actually, the Gem crashes seem to be unrelated, so scratch that. But what I
can say with confidence is that in HEAD with nw.js 0.46.3, drawing data
structures stopped working for me (even in the most basic examples).

Albert


On Tue, Jun 30, 2020 at 7:19 PM Albert Graef <aggraef at gmail.com> wrote:

> Hi Jonathan,
>
> thanks for clearing that up. I've rebuilt the package with 0.46.3 now (on
> Arch x86_64). Most simple patches load and work fine with it, but lots of
> the more advanced stuff is broken. E.g., the About patch comes up empty and
> (adding insult to injury) the window cannot be closed any more, giving the
> error message shown in the screenshot:
>
> [image: image.png]
>
> In fact, drawing of data structures seems to be completely broken (not
> just the purr-data svg drawing extensions, but plain old vanilla data
> structures, too).
>
> Gem also stopped working. Even the most basic examples crash Purr Data
> (segfault) as soon as you try to create a Gem window.
>
> This is all stuff that worked fine in rev. 4b7b73cd from 2 weeks ago.
>
> I hate to say it, but these latest changes are not ready for prime time
> yet. IMHO, they absolutely need to be moved back to their own feature
> branch and tested out *much* more thoroughly before they can be merged
> again. Right now, if anyone wants to try the latest from the master branch,
> she can only conclude that Purr Data is broken (at least on Linux, I didn't
> do any testing on Mac or Windows). That's not the impression we want to
> give, do we?
>
> I can understand that you want to move on with these things, but if a
> changeset is highly experimental and carries with it so much potential for
> breakage, then it needs to be given some serious regression testing. Please
> don't break the master branch, that's what feature branches are for. ;-)
>
> To get us out of here quickly and easily, you might just branch off a new
> "stable" branch at rev. 4b7b73cd and present that as our new official main
> branch to users (and also turn that inthe default branch of the repo)?
> Whereas "master" will become our development branch?
>
> Albert
>
>
> On Tue, Jun 30, 2020 at 2:14 PM Jonathan Wilkes <jon.w.wilkes at gmail.com>
> wrote:
>
>> On Tue, Jun 30, 2020 at 6:30 AM Albert Graef <aggraef at gmail.com> wrote:
>> >
>> > Hi Sam,
>> >
>> > No, I'm using 0.24.4, which is the default version of nw.js on Linux
>> that's supported in our build system. In any case, I'm using the same
>> version as with the last release and with the last-known-working revision.
>> >
>> > Perhaps I've missed a stealth update of the nw.js version in recent
>> times? ;-) If so, then the update *must* be reflected in the build system,
>> and we should all be very cautious about all kinds of possible regressions
>> due to the version update.
>>
>> So my plan was to do a smaller bugfix release yesterday with a few
>> patches which Ico had told me don't depend on a
>> newer version of nw.js.
>>
>> But his "patchset from hell" has inscrutable interdependencies on each
>> other. So even those merges
>> still required the updated version.
>>
>> I can confirm running HEAD against a local 0.46.3 nw.js on aarch64
>> does indeed work to load and display patches.
>>
>> I'll update the binaries and build script.
>>
>> On a related note-- apparently "feature-branch" isn't enough to convey
>> the dev process I want here.
>>
>> What do I need to add to the contributor's guide to make it clear what
>> a desirable merge request branch should look like?
>>
>> -Jonathan
>>
>>
>> >
>> > Best,
>> > Albert
>> >
>> >
>> > On Tue, Jun 30, 2020 at 11:42 AM Sam Thursfield <ssssam at gmail.com>
>> wrote:
>> >>
>> >> Hi Albert,
>> >>
>> >> On Tue, Jun 30, 2020 at 9:12 AM Albert Graef <aggraef at gmail.com>
>> wrote:
>> >> > The program still builds fine, launches and I can still open new
>> patch windows (^n), but "About Pd-L2ork" doesn't work any more and I can't
>> open existing patches either (apparently the patches do get opened in the
>> engine, but no window is mapped).
>> >>
>> >> Is it possible that you are using a version of nw.js >= 0.42.3 ?
>> >> This issue sounds a bit like
>> >> https://git.purrdata.net/jwilkes/purr-data/-/issues/572
>> >> Sam
>> >> _______________________________________________
>> >> L2Ork-dev mailing list
>> >> L2Ork-dev at disis.music.vt.edu
>> >> https://disis.music.vt.edu/listinfo/l2ork-dev
>> >
>> >
>> >
>> > --
>> > Dr. Albert Gr"af
>> > Computer Music Research Group, JGU Mainz, Germany
>> > Email: aggraef at gmail.com, web: https://agraef.github.io/
>> > _______________________________________________
>> > L2Ork-dev mailing list
>> > L2Ork-dev at disis.music.vt.edu
>> > https://disis.music.vt.edu/listinfo/l2ork-dev
>> _______________________________________________
>> L2Ork-dev mailing list
>> L2Ork-dev at disis.music.vt.edu
>> https://disis.music.vt.edu/listinfo/l2ork-dev
>
>
>
> --
> Dr. Albert Gr"af
> Computer Music Research Group, JGU Mainz, Germany
> Email: aggraef at gmail.com, web: https://agraef.github.io/
>


-- 
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com, web: https://agraef.github.io/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20200630/4d13bf44/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 378398 bytes
Desc: not available
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20200630/4d13bf44/attachment-0001.png>