[L2Ork-dev] Test upcoming bugfix for glist_getcanvas

[Ivica Ico Bukvic]

I have a vague recollection that this may have to do with nested GOPs 
(e.g. if you adjust a parent GOP, nested ones need to be re-checked), 
but may be mis-remembering.

Best,

Ico


On 11/17/2017 4:54 PM, Jonathan Wilkes wrote:
> Hi list,
> I've got a crasher fix in the pipeline:
>
> https://git.purrdata.net/jwilkes/purr-data/commits/gop-crasher-fix
>
> Essentially this just removes gobj_shouldvis from the conditional in 
> glist_getcanvas.
>
> Any clue what the heck that call was doing there in the first place? 
> It was in Pd-extended
> 0.42, then removed without comment or explanation for Pd-extended 0.43.
>
> The crasher happened because the glist_getcanvas loop assumes only 
> that the current
> glist and its owner are valid, but the call to glist_shouldvis ends up 
> calling glist_xtopixels
> and dereferencing a glist one past the owner.
>
> I don't currently see any regressions due to removing it, but it 
> should be thoroughly
> tested before moving on.
>
> -Jonathan
>
>
>
> _______________________________________________
> L2Ork-dev mailing list
> L2Ork-dev at disis.music.vt.edu
> https://disis.music.vt.edu/listinfo/l2ork-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20171117/ef2124b5/attachment.html>