[L2Ork-dev] gui port
Jonathan Wilkes
jancsika at yahoo.com
Fri Jun 24 05:56:28 UTC 2016
What's the benefit of doing a pull request (or what gitlab calls merge request)
vs. git format-patch?
-Jonathan
On Friday, June 24, 2016 12:50 AM, Albert Graef <aggraef at gmail.com> wrote:
Thanks. :) I've updated the Arch PKGBUILD and the debuild stuff to add the missing nw.js dependencies, and my latest Launchpad test build is looking good so far. Once that is finished, I can send you my changes to debuild to make it work with purr-data. May take a few hours, though, since I also have to teach courses today.
Is there a way to do pull requests on your GitLab instance, or should I just send you a good old-fashioned patch?
On Fri, Jun 24, 2016 at 5:47 AM, Jonathan Wilkes <jancsika at yahoo.com> wrote:
Got it.
Show original message On Thursday, June 23, 2016 11:36 PM, Albert Graef <aggraef at gmail.com> wrote:
Jonathan, concerning your latest commit "remove flext binary files that accidentally got added to the repo": That's not good enough, there are still binaries in there. Please nuke the whole externals/grill/trunk/flext/libbuild/ and externals/grill/trunk/flext/pd-linux/ directories, they shouldn't be in the sources at all.
On Thu, Jun 23, 2016 at 7:32 PM, Albert Graef <aggraef at gmail.com> wrote:
On Thu, Jun 23, 2016 at 6:39 PM, Jonathan Wilkes <jancsika at yahoo.com> wrote:
Ok, I'll take a look later and clean it up.
Thanks. I'll wait for that before I send you my changes to the debuild stuff.
I've ported the debuild to purr-data now. Works fine locally already, but I still need to test it on Launchpad.
--
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com
WWW: https://plus.google.com/+AlbertGraef
--
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com
WWW: https://plus.google.com/+AlbertGraef
--
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com
WWW: https://plus.google.com/+AlbertGraef
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20160624/f56461ed/attachment-0001.html>
More information about the L2Ork-dev
mailing list