<html><head></head><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div id="yui_3_16_0_ym19_1_1466747057176_7563"><span id="yui_3_16_0_ym19_1_1466747057176_7625">What's the benefit of doing a pull request (or what gitlab calls merge request) <br></span></div><div id="yui_3_16_0_ym19_1_1466747057176_7626"><span id="yui_3_16_0_ym19_1_1466747057176_7625">vs. git format-patch?</span></div><div id="yui_3_16_0_ym19_1_1466747057176_7655"><br><span id="yui_3_16_0_ym19_1_1466747057176_7625"></span></div><div id="yui_3_16_0_ym19_1_1466747057176_7656"><span id="yui_3_16_0_ym19_1_1466747057176_7625">-Jonathan</span></div> <div class="qtdSeparateBR"><br><br></div><div style="display: block;" class="yahoo_quoted"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div dir="ltr"><font face="Arial" size="2"> On Friday, June 24, 2016 12:50 AM, Albert Graef <aggraef@gmail.com> wrote:<br></font></div> <br><br> <div class="y_msg_container"><div id="yiv5066749962"><div><div dir="ltr">Thanks. :) I've updated the Arch PKGBUILD and the debuild stuff to add the missing nw.js dependencies, and my latest Launchpad test build is looking good so far. Once that is finished, I can send you my changes to debuild to make it work with purr-data. May take a few hours, though, since I also have to teach courses today.<br clear="none"><br clear="none">Is there a way to do pull requests on your GitLab instance, or should I just send you a good old-fashioned patch?<br clear="none"></div><div class="yiv5066749962gmail_extra"><br clear="none"><div class="yiv5066749962yqt3872159939" id="yiv5066749962yqt83100"><div class="yiv5066749962gmail_quote">On Fri, Jun 24, 2016 at 5:47 AM, Jonathan Wilkes <span dir="ltr"><<a rel="nofollow" shape="rect" ymailto="mailto:jancsika@yahoo.com" target="_blank" href="mailto:jancsika@yahoo.com">jancsika@yahoo.com</a>></span> wrote:<br clear="none"><blockquote class="yiv5066749962gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div style="color:#000;background-color:#fff;font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"><div><span>Got it.</span></div> <div><br clear="none"><br clear="none"></div><div title="Show original message"> <span></span> <span>Show original message</span> </div><div><div class="yiv5066749962h5"><div style="display:block;"> <div style="font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"> <div style="font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"> <div dir="ltr"><font face="Arial" size="2"> On Thursday, June 23, 2016 11:36 PM, Albert Graef <<a rel="nofollow" shape="rect" ymailto="mailto:aggraef@gmail.com" target="_blank" href="mailto:aggraef@gmail.com">aggraef@gmail.com</a>> wrote:<br clear="none"></font></div> <br clear="none"><br clear="none"> <div><div><div><div dir="ltr">Jonathan, concerning your latest commit "remove flext binary files that accidentally got added to the repo": That's not good enough, there are still binaries in there. Please nuke the whole externals/grill/trunk/flext/libbuild/ and externals/grill/trunk/flext/pd-linux/ directories, they shouldn't be in the sources at all.<br clear="none"></div><div><br clear="none"><div><div>On Thu, Jun 23, 2016 at 7:32 PM, Albert Graef <span dir="ltr"><<a rel="nofollow" shape="rect" ymailto="mailto:aggraef@gmail.com" target="_blank" href="mailto:aggraef@gmail.com">aggraef@gmail.com</a>></span> wrote:<br clear="none"><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr"><span></span><div><div>On Thu, Jun 23, 2016 at 6:39 PM, Jonathan Wilkes <span dir="ltr"><<a rel="nofollow" shape="rect" ymailto="mailto:jancsika@yahoo.com" target="_blank" href="mailto:jancsika@yahoo.com">jancsika@yahoo.com</a>></span> wrote:<br clear="none"><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Ok, I'll take a look later and clean it up.</blockquote></div><br clear="none"></div><div>Thanks. I'll wait for that before I send you my changes to the debuild stuff.<br clear="none"></div><div><br clear="none"></div><div>I've ported the debuild to purr-data now. Works fine locally already, but I still need to test it on Launchpad.<br clear="all"></div><span></span><div><br clear="none">-- <br clear="none"><div><div dir="ltr">Dr. Albert Gr"af<br clear="none">Computer Music Research Group, JGU Mainz, Germany<br clear="none">Email: <a rel="nofollow" shape="rect" ymailto="mailto:aggraef@gmail.com" target="_blank" href="mailto:aggraef@gmail.com">aggraef@gmail.com</a><br clear="none">WWW: <a rel="nofollow" shape="rect" target="_blank" href="https://plus.google.com/+AlbertGraef">https://plus.google.com/+AlbertGraef</a></div></div>
</div></div>
</blockquote></div></div><br clear="none"><br clear="all"><br clear="none">-- <br clear="none"><div><div dir="ltr">Dr. Albert Gr"af<br clear="none">Computer Music Research Group, JGU Mainz, Germany<br clear="none">Email: <a rel="nofollow" shape="rect" ymailto="mailto:aggraef@gmail.com" target="_blank" href="mailto:aggraef@gmail.com">aggraef@gmail.com</a><br clear="none">WWW: <a rel="nofollow" shape="rect" target="_blank" href="https://plus.google.com/+AlbertGraef">https://plus.google.com/+AlbertGraef</a></div></div>
</div></div></div><br clear="none"><br clear="none"></div> </div> </div> </div></div></div></div></div></blockquote></div></div><br clear="none"><br clear="all"><br clear="none">-- <br clear="none"><div class="yiv5066749962gmail_signature"><div dir="ltr">Dr. Albert Gr"af<br clear="none">Computer Music Research Group, JGU Mainz, Germany<br clear="none">Email: <a rel="nofollow" shape="rect" ymailto="mailto:aggraef@gmail.com" target="_blank" href="mailto:aggraef@gmail.com">aggraef@gmail.com</a><br clear="none">WWW: <a rel="nofollow" shape="rect" target="_blank" href="https://plus.google.com/+AlbertGraef">https://plus.google.com/+AlbertGraef</a></div></div>
</div></div></div><br><br></div> </div> </div> </div></div></body></html>