[L2Ork-dev] Current HEAD of Purr Data is broken

Albert Graef aggraef at gmail.com
Thu Jul 2 03:36:58 EDT 2020

On Thu, Jul 2, 2020 at 4:05 AM Jonathan Wilkes <jon.w.wilkes at gmail.com>

> Anyhow, I think as you've pointed out it's just as easy to make a series
> of commits to a feature branch as it is
> to master.

Exactly. It's even easier, because you can just rebase and rewrite history
via `git push -f` at any time, which isn't recommended (or even forbidden)
on master.

On another note-- 0.46.3 with Ico's changes is *slow* on my slow laptop
> (about like an RPI 4). Like, unusably slow for patches that have a lot of
> objects on the toplevel.

I noticed those slowdowns as well. :( That's why I had to go back to rev.
4b7b73cd and nw.js 0.24.4 for now.

We can't ship a release that takes an order of magnitude longer to load
> patches. We'll need to spend some serious
> time in devTools profiling this, and getting load time back down to
> reasonable levels before releasing.

I fully agree with that. Ico's patchset looks very interesting and
promising, but it's obvious that it needs more work. So let's move it back
into a separate feature branch for now, where work can continue on it
without blocking everything and everyone else.

Jonathan, I assume that you want to keep linear history on master at all
costs, and thus prefer *not* to rebase the master branch? Then we'd have to
put everything to be rolled back in one big reversal commit, cherry-pick
the commits belonging to Ico's changeset to a new branch and create a merge
request for that new branch. Ico can then check out that branch and
continue work on it and push to the MR (where others like me can continue
to test it), while the master branch will be back in a known good state.

That's my basic plan, but let me figure out a process for that on a test
branch first, so that we don't wreak havoc on the master branch again. ;-)
I have to teach courses today, but I can hopefully set aside some time to
have a look at this later today.


Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com, web: https://agraef.github.io/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20200702/23250418/attachment.html>

More information about the L2Ork-dev mailing list