<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 25, 2020 at 2:57 AM Albert Graef <<a href="mailto:aggraef@gmail.com">aggraef@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 24, 2020 at 6:12 PM Jonathan Wilkes <<a href="mailto:jon.w.wilkes@gmail.com" target="_blank">jon.w.wilkes@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I think there is another-- instead of triggering the beginning of the<br>
mode on `<ctrl>`, we could trigger it on click.</blockquote><div><br></div><div>That sounds like the most sensible solution.</div></div></div></blockquote><div><br></div><div>Or maybe not. On second thought, I think that we want to give immediate visual feedback when the user enters temp runmode, especially now that we have the editmode grid. If we defer that until actually clicking something, that doesn't provide immediate feedback any more. This is true no matter whether Ctrl or Alt is the modifier.</div><div><br></div><div>Now we may be able to fudge that by just handling the visual feedback on the spot in the GUI as soon as the user presses the temp runmode key. But if we return to Ctrl that means that we still have that annoying flashing of the grid whenever the user presses Ctrl to enter a menu shortcut. Look at it any way you like, if we want to give immediate visual feedback for temp runmode (and I think we should), then having Ctrl bound to that function is just more trouble than it's worth. Vanilla can get away with that only because it hardly provides any visual cues in that case and hence there's no such flashing effect (other than the cursor changing shape, which is easy to ignore).<br></div><div><br></div><div>It's really a tricky issue. All in all, I think that the switch to the Alt key provides the cleanest solution, because it eradicates most of these annoying side-effects in one fell swoop. There's still the issue that Joseph reported, with Alt-click not exiting temporary runmode after opening a subpatch. But I think that this is a minor bug which can actually be fixed by Jonathan's first method (sending a fake Alt keyup in the corresponding click handler). This will be *much* easier than having to fake those keyups in every single menu handler that may invoke a popup, so I think that I'll be able to implement this by myself without too much difficulty. I'll look into that next.</div><div><br></div><div>Albert</div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> But is that really the only thing that you can do in temp runmode? (Sorry, I'm not actually that familiar with temp runmode, I don't really use it a lot myself.)</div><div><br></div><div>Also, do you think that this also solves the popup-swallows-ctrl-key-up bug in the case of an abstraction click in temp runmode? (Joseph just reported this for 2.14.2, it's the one popup issue which remains the same with the Alt keybinding.)</div><div><br></div><div>Albert</div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Then we can just look<br>
to see if there's a `<ctrl>` modifier with the click, and if so send<br>
that `<ctrl>` key event to the backend. Now the backend can wait with<br>
impunity for the `<ctrl>` keyup since we know the user is in the midst<br>
of a click.<br>
<br>
To be completist we could do the same for an initial mousemove event<br>
to check if `<ctrl>` is depressed. That would leave a single esoteric<br>
bug, which is that the user wouldn't be able to trigger a pointer<br>
cursor change-- say, hovering over a scalar's clickable hotspot--<br>
simple by depressing and release `<ctrl>`.<br>
<br>
-Jonathan<br>
<br>
><br>
>> I vote for keeping the <ctrl> binding.<br>
><br>
><br>
> Counted, thanks.<br>
><br>
> It probably doesn't come as a big surprise that I vote for the Alt key myself. ;-)<br>
><br>
> Anyone else? Ico, IIRC it was actually you who originally suggested the Alt key (or would at least be fine with it), so what's your vote then?<br>
><br>
> Cheers,<br>
> Albert<br>
><br>
>> >>> I also see the new grid in Edit mode. Is there any way to snap to this grid?<br>
>> >><br>
>> >> And this...?<br>
>> >> _______________________________________________<br>
>> >> L2Ork-dev mailing list<br>
>> >> <a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
>> >> <a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > Dr. Albert Gr"af<br>
>> > Computer Music Research Group, JGU Mainz, Germany<br>
>> > Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>, web: <a href="https://agraef.github.io/" rel="noreferrer" target="_blank">https://agraef.github.io/</a><br>
>> > _______________________________________________<br>
>> > L2Ork-dev mailing list<br>
>> > <a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
>> > <a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a><br>
>> _______________________________________________<br>
>> L2Ork-dev mailing list<br>
>> <a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
>> <a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a><br>
><br>
><br>
><br>
> --<br>
> Dr. Albert Gr"af<br>
> Computer Music Research Group, JGU Mainz, Germany<br>
> Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>, web: <a href="https://agraef.github.io/" rel="noreferrer" target="_blank">https://agraef.github.io/</a><br>
> _______________________________________________<br>
> L2Ork-dev mailing list<br>
> <a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
> <a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a><br>
_______________________________________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a></blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Dr. Albert Gr"af<br>Computer Music Research Group, JGU Mainz, Germany<br>Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>, web: <a href="https://agraef.github.io/" target="_blank">https://agraef.github.io/</a></div></div></div></div></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Dr. Albert Gr"af<br>Computer Music Research Group, JGU Mainz, Germany<br>Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>, web: <a href="https://agraef.github.io/" target="_blank">https://agraef.github.io/</a></div></div></div></div></div></div></div>