<div dir="auto">I propose proceeding with whatever is easiest, most maintainable, and least likely to break things. So, cherry picking fixes will be important.<br><br><div data-smartmail="gmail_signature">Best,<br><br>Ico<br><br>-- <br>Ivica Ico Bukvic, D.M.A.<br>Director, Creativity + Innovation<br>Institute for Creativity, Arts, and Technology<br><br>Virginia Tech<br>Creative Technologies in Music<br>School of Performing Arts – 0141<br>Blacksburg, VA 24061<br>(540) 231-6139<br><a href="mailto:ico@vt.edu">ico@vt.edu</a><br><br><a href="http://www.icat.vt.edu">www.icat.vt.edu</a><br><a href="http://www.performingarts.vt.edu">www.performingarts.vt.edu</a><br><a href="http://l2ork.icat.vt.edu">l2ork.icat.vt.edu</a><br><a href="http://ico.bukvic.net">ico.bukvic.net</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 16, 2020, 11:47 Guillem Bartrina Moreno <<a href="mailto:guillembartrina@gmail.com">guillembartrina@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,</div><div>I have been checking pd vanilla "triggerize" feature, as Matt suggested, together with its undo system. It turns out that pd vanilla already has an atomic multi-step undo system implemented that allows us to start a sequence of undo actions, fill it with all actions that we need and then finalize it. Then, while undoing, if the system encounters the start/end of the sequence it executes all undo steps until the end/start is reached.</div><div>As you have been talking about merging some pd vanilla interesting features into purr data, what do you think about this one?</div><div>I don't know what would be better. I have checked the implementation differences between vanilla and purr data and there are some of them that could probably break the system if we do a direct merge. Basically pd vanilla changed the place where the undo queue is stored and therefore how it's accessed, and some other implementation differences and add-ons.</div><div>An option would be porting only the things that we want to add to purr data, adjusting them as needed. Another one would be implementing them from scratch, as intended.</div><div><br></div><div>Best,</div><div><br></div>-- <br><div dir="ltr" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2" face="arial, helvetica, sans-serif">Guillem Bartrina Moreno</font></div></div></div></div></div></div></div>
_______________________________________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank" rel="noreferrer">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer noreferrer" target="_blank">https://disis.music.vt.edu/listinfo/l2ork-dev</a></blockquote></div>