<div dir="ltr"><div><div>Ico, I think that what Jonathan tried to say (maybe he should have been more blunt about it), is that the existing flext build system just can't be used any more without breaking the continuous integration stuff he has in place. The CI is really important. It does all builds automatically at all times so that we can *always* be sure that, whatever goes in, also builds on all the supported platforms. It took a while to get it there, so that's not something to be toyed with.<br><br></div>If we want flext in there, its build system needs to be fixed up so that it builds on first attempt, without any horrible kludges and manual intervention. Simple as that. So someone needs to put the effort in. Not me either. :)<br><br></div>Albert<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 2, 2018 at 3:32 PM, Ivica Ico Bukvic <span dir="ltr"><<a href="mailto:ico@vt.edu" target="_blank">ico@vt.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you, Jonathan. Would it be possible to simply borrow then 1.0 build scripts for flext or are there other issues pertaining to Windows and/or OSX?<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 3/2/2018 12:18 AM, Jonathan Wilkes wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Mar 1, 2018 at 11:24 PM, Ivica Ico Bukvic <<a href="mailto:ico@vt.edu" target="_blank">ico@vt.edu</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I understand that flext not building easily or at all using the build<br>
environment Jonathan set up is an issue. I am, however, reluctant on letting<br>
go of flext as there are other externals it offers like pyext that can be<br>
particularly useful. Is there anyone in the community who may be willing to<br>
help with trying to build flext using Jonathan's build tools? Jonathan, is<br>
there a page that describes what these tools are exactly and what were the<br>
issues that prevented flext from building, so that we can take it from<br>
there?<br>
</blockquote>
The build tools are exactly the same as the ones in Pd-l2ork 1.0-- a<br>
set of recursive<br>
makefiles which call external library makefiles as specified in<br>
externals/Makefile.<br>
<br>
I vaguely remember it not building under msys2 which is the environment used<br>
for building Purr Data under Windows. I do remember noticing<br>
that flext uses a set of custom build scripts and has its own package file<br>
format.<br>
<br>
Then I noticed that the main build script for flext isn't idempotent.<br>
You have to run<br>
it once, manually edit a file that gets created, then run it again.<br>
<br>
Finally, I noticed that the recipe in externals/Makefile for building<br>
flext under<br>
Pd extended actually ran the build script THREE times instead of two.<br>
<br>
With that in mind, my strong suggestion is for someone to improve flext's<br>
build system upstream and make it use one of the several standard build<br>
systems instead of a set of custom scripts which are difficult to reason about.<br>
In this case we could easily ship it with Purr Data and easily maintain it.<br>
<br>
If that isn't possible, I'll happily accept merge requests for building/shipping<br>
flext as long as the submitter agrees to maintain it going forward<br>
instead of me.<br>
<br>
-Jonathan<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thank you.<br>
<br>
Best,<br>
<br>
Ico<br>
<br>
<br>
<br>
On 2/28/2018 6:24 PM, Jonathan Wilkes wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hm... what is the point of variables like grate_var_connected? It<br>
appears to get set but not used, unless I'm missing some C++/Flext<br>
magic...<br>
<br>
Also, what's the point of tempgrate vs. using a function local tmp<br>
variable?<br>
<br>
If none of those are needed it looks like I can just bind some<br>
ancillary float inlets to relevant struct members.<br>
<br>
-Jonathan<br>
<br>
On Wed, Feb 28, 2018 at 5:27 PM, Jonathan Wilkes <<a href="mailto:jon.w.wilkes@gmail.com" target="_blank">jon.w.wilkes@gmail.com</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If someone can make a wrapper for the STK C++ library calls I can just<br>
try porting it to C.<br>
<br>
-Jonathan<br>
<br>
On Wed, Feb 28, 2018 at 3:14 PM, Alberto Zin <<a href="mailto:alberto.zin@gmail.com" target="_blank">alberto.zin@gmail.com</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Compiling disis_munger~ is not for the faint-hearted, (it requires flext<br>
build system in place), so I hope it will be built automatically again..<br>
<br>
Alberto<br>
<br>
2018-02-28 14:38 GMT+01:00 Albert Graef <<a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It's in <a href="https://git.purrdata.net/jwilkes/purr-data/commit/e72deb8d" rel="noreferrer" target="_blank">https://git.purrdata.net/jwilk<wbr>es/purr-data/commit/e72deb8d</a>, and<br>
it<br>
says right in the commit message that disis_munger was excluded, but<br>
not<br>
why. :)<br>
<br>
On Wed, Feb 28, 2018 at 2:35 PM, Albert Graef <<a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yep, it's not being built. Which might be due to the fact that it<br>
still<br>
sits in its own subdir in l2ork_addons/, whereas the other DISIS<br>
externals<br>
were moved to externals/disis/ a while back. Jonathan, maybe you<br>
missed that<br>
one? Or maybe it was just never being built? Let me try to find that<br>
commit...<br>
<br>
On Wed, Feb 28, 2018 at 12:24 PM, Alberto Zin <<a href="mailto:alberto.zin@gmail.com" target="_blank">alberto.zin@gmail.com</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello, I use Albert's repository for getting and update purr-data on<br>
Linux mint 18.03 (based on Ubuntu 16.04). is it just me or<br>
disis_munger~.<br>
pd_linux is missing/not compiled?<br>
Thanks, Alberto.<br>
<br>
<br>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote>
<br>
<br>
<br>
--<br>
Dr. Albert Gr"af<br>
Computer Music Research Group, JGU Mainz, Germany<br>
Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a><br>
WWW: <a href="https://plus.google.com/+AlbertGraef" rel="noreferrer" target="_blank">https://plus.google.com/+Alber<wbr>tGraef</a><br>
</blockquote>
<br>
<br>
<br>
--<br>
Dr. Albert Gr"af<br>
Computer Music Research Group, JGU Mainz, Germany<br>
Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a><br>
WWW: <a href="https://plus.google.com/+AlbertGraef" rel="noreferrer" target="_blank">https://plus.google.com/+Alber<wbr>tGraef</a><br>
<br>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote>
<br>
<br>
<br>
--<br>
<a href="https://soundcloud.com/albertoz" rel="noreferrer" target="_blank">https://soundcloud.com/alberto<wbr>z</a><br>
<a href="https://www.flickr.com/photos/94787902@N08/" rel="noreferrer" target="_blank">https://www.flickr.com/photos/<wbr>94787902@N08/</a><br>
<a href="http://sites.google.com/site/albertozin/" rel="noreferrer" target="_blank">http://sites.google.com/site/a<wbr>lbertozin/</a><br>
<br>
47 41 4d 45 20 4f 56 45 52<br>
<br>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote></blockquote>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote>
<br>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a><br>
</blockquote>
<br>
______________________________<wbr>_________________<br>
L2Ork-dev mailing list<br>
<a href="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank">L2Ork-dev@disis.music.vt.edu</a><br>
<a href="https://disis.music.vt.edu/listinfo/l2ork-dev" rel="noreferrer" target="_blank">https://disis.music.vt.edu/lis<wbr>tinfo/l2ork-dev</a></div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Dr. Albert Gr"af<br>Computer Music Research Group, JGU Mainz, Germany<br>Email: <a href="mailto:aggraef@gmail.com" target="_blank">aggraef@gmail.com</a><br>WWW: <a href="https://plus.google.com/+AlbertGraef" target="_blank">https://plus.google.com/+AlbertGraef</a></div></div>
</div>