<html><head></head><body><div style="color:#000; background-color:#fff; font-family:Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:13px"><div>Hi list,</div><div>I've got a crasher fix in the pipeline:</div><div id="yui_3_16_0_ym19_1_1510955229782_4400"><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4106" dir="ltr"><a id="yui_3_16_0_ym19_1_1510955229782_4105" class="" href="https://git.purrdata.net/jwilkes/purr-data/commits/gop-crasher-fix">https://git.purrdata.net/jwilkes/purr-data/commits/gop-crasher-fix</a></div><div><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4190" dir="ltr">Essentially this just removes gobj_shouldvis from the conditional in glist_getcanvas.</div><div id="yui_3_16_0_ym19_1_1510955229782_4219" dir="ltr"><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4220" dir="ltr">Any clue what the heck that call was doing there in the first place? It was in Pd-extended <br></div><div id="yui_3_16_0_ym19_1_1510955229782_4298" dir="ltr">0.42, then removed without comment or explanation for Pd-extended 0.43.</div><div id="yui_3_16_0_ym19_1_1510955229782_4299" dir="ltr"><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4309" dir="ltr">The crasher happened because the glist_getcanvas loop assumes only that the current <br></div><div id="yui_3_16_0_ym19_1_1510955229782_4300" dir="ltr">glist and its owner are valid, but the call to glist_shouldvis ends up calling glist_xtopixels <br></div><div id="yui_3_16_0_ym19_1_1510955229782_4322" dir="ltr">and dereferencing a glist one past the owner.<br></div><div id="yui_3_16_0_ym19_1_1510955229782_4308" dir="ltr"><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4362" dir="ltr">I don't currently see any regressions due to removing it, but it should be thoroughly <br></div><div id="yui_3_16_0_ym19_1_1510955229782_4361" dir="ltr">tested before moving on.</div><div id="yui_3_16_0_ym19_1_1510955229782_4371" dir="ltr"><br></div><div id="yui_3_16_0_ym19_1_1510955229782_4372" dir="ltr">-Jonathan<br> </div><div id="yui_3_16_0_ym19_1_1510955229782_4029"><br></div></div></body></html>