<html><head></head><body><div style="color:#000; background-color:#fff; font-family:Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:13px"><div><span></span></div><div class="qtdSeparateBR"><br><br></div><div class="yahoo_quoted" id="yui_3_16_0_1_1490545368428_7223" style="display: block;"><font size="2"><font face="Arial">> </font></font>That was so long ago I honestly don't remember. What I do
remember is that I had to take several stabs at this until I got
it right. So, there may be another commit on top of this that does
this the right way. If Purr-Data's current behavior matches that
of the latest pd-l2ork, then this fix may have been superseded by
another.<br clear="none">
<div style="font-family: Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 13px;" id="yui_3_16_0_1_1490545368428_7222"><div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;" id="yui_3_16_0_1_1490545368428_7221"><div class="y_msg_container" id="yui_3_16_0_1_1490545368428_7256"><div id="yiv4071817082"><div id="yui_3_16_0_1_1490545368428_7255"><div>
</div><div id="yui_3_16_0_1_1490545368428_7292"><br></div><div id="yui_3_16_0_1_1490545368428_7323" dir="ltr">They both set the "mode" based on the type of the first argument. AFAICT the <br></div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7357">singular change was from using argv[n] to using argv[0].</div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7372"><br></div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7457">Because of this we can't mix float and symbol arguments in [select]. But you <br></div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7465">made changes to [route] that does allow to mix float and symbol arguments. That's <br></div><div dir="ltr">essentially the same interface with a payload as output, so I'm not sure why [select] <br></div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7540">mixed mode would have caused problems.</div><div dir="ltr"><br></div><div dir="ltr" id="yui_3_16_0_1_1490545368428_7542">-Jonathan<br></div><div id="yui_3_16_0_1_1490545368428_7290">
<br></div><div class="yiv4071817082yqt8517995825" id="yiv4071817082yqt00998"><div class="yiv4071817082moz-cite-prefix" id="yui_3_16_0_1_1490545368428_7288">On 3/25/2017 9:44 PM, Jonathan Wilkes
wrote:<br clear="none">
</div>
<blockquote type="cite" id="yui_3_16_0_1_1490545368428_7260">
<div style="color:#000;background-color:#fff;font-family:Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:13px;" id="yui_3_16_0_1_1490545368428_7259">
<div id="yui_3_16_0_1_1490545368428_7258">Hello,</div>
<div id="yiv4071817082yui_3_16_0_1_1490484570129_24153">I just noticed this:</div>
<div id="yui_3_16_0_1_1490545368428_7263"><br clear="none">
</div>
<div id="yiv4071817082yui_3_16_0_1_1490484570129_24177">commit
5e18b837acd440ac4751c90c0c0b1e4a71623a2e<br clear="none">
Author: Ivica Ico Bukvic <a rel="nofollow" shape="rect" class="yiv4071817082moz-txt-link-rfc2396E" ymailto="mailto:ico@vt.edu" target="_blank" href="mailto:ico@vt.edu"><ico@vt.edu></a><br clear="none">
Date: Thu Jul 18 16:41:53 2013 -0400<br clear="none">
<br clear="none">
fixed regression in select due to
37c0cf150e42e0277a0496cb73d48a114c64f0e7 commit which made it
behave inconsistently thus making it impossible for floats to
be treated as symbols (in cases where first argument was a
symbol). Also introduced similar fix to the route object, thus
allowing for second inlet to receive either float or symbol<br clear="none">
</div>
<div id="yiv4071817082yui_3_16_0_1_1490484570129_24189"><br clear="none">
</div>
<div>***</div>
<div id="yiv4071817082yui_3_16_0_1_1490484570129_24263"><br clear="none">
</div>
<div>What is the regression that this was meant to fix? Basing
the object's "mode" off of the type <br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24280">of the
first argument as this commit does will _not_ allow floats to
be treated as symbols as the <br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24264">commit
message suggests.</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24281"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24289">If the
implication is that you want this to work:</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24291">[42(</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24299">|</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24300">[makefilename
%d]</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24301">|</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24306">[select
blah 42]</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24343"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24344">Then the
implication is wrong, because you don't get a match that way
under any version of <br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24345">[select]
for any version of Pd. Instead you get a match for the "42"
slot on this:</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24346"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24347">[symbol(</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24390">|</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24358">[select
blah 42]</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24367"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24398">That is,
_any_ numeric argument will match an incoming empty symbol
because that's what <br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24399">the
SETSYMBOL macro does when you feed it a floatarg.</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24422"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24423">I'd like to
revert back to my "mixed" mode algorithm so that the "42" slot
matches on this:</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24424"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24425">[42(</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24434">|</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24433">[select
blah 42]</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24439"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24447">and the
"blah" slot matches on this:</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24448"><br clear="none">
</div>
<div dir="ltr">[symbol blah(</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24449">|</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24461">[select 42
blah]</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24484"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24485">Mixing arg
types isn't very common, but this is the only sane behavior I
can think of (and it <br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24486">shouldn't
have broken any patches in all the time [select] behaved this
way in Pd-l2ork).</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24487"><br clear="none">
</div>
<div dir="ltr" id="yiv4071817082yui_3_16_0_1_1490484570129_24488">-Jonathan<br clear="none">
</div>
</div>
<br clear="none">
<fieldset class="yiv4071817082mimeAttachmentHeader"></fieldset>
<br clear="none">
<pre>_______________________________________________
L2Ork-dev mailing list
<a rel="nofollow" shape="rect" class="yiv4071817082moz-txt-link-abbreviated" ymailto="mailto:L2Ork-dev@disis.music.vt.edu" target="_blank" href="mailto:L2Ork-dev@disis.music.vt.edu">L2Ork-dev@disis.music.vt.edu</a>
<a rel="nofollow" shape="rect" class="yiv4071817082moz-txt-link-freetext" target="_blank" href="http://disis.music.vt.edu/listinfo/l2ork-dev">http://disis.music.vt.edu/listinfo/l2ork-dev</a></pre>
</blockquote></div>
<br clear="none">
</div></div><div class="yqt8517995825" id="yqt87564">_______________________________________________<br clear="none">L2Ork-dev mailing list<br clear="none"><a shape="rect" ymailto="mailto:L2Ork-dev@disis.music.vt.edu" href="mailto:L2Ork-dev@disis.music.vt.edu">L2Ork-dev@disis.music.vt.edu</a><br clear="none"><a shape="rect" href="http://disis.music.vt.edu/listinfo/l2ork-dev" target="_blank">http://disis.music.vt.edu/listinfo/l2ork-dev</a></div><br><br></div> </div> </div> </div></div></body></html>