<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Perfect, thank you, Albert.</p>
<p>I think we should also fix the bendin regardless of legacy stuff.</p>
<p>Best,</p>
<p>Ico<br>
</p>
<br>
<div class="moz-cite-prefix">On 6/13/2016 3:51 PM, Albert Graef
wrote:<br>
</div>
<blockquote
cite="mid:CA+rUic1QDOoisOTe9RTKTWQN7tB1xo1XbhLwnJ0KqcmVEEw+Eg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>Hi Ico,<br>
<br>
</div>
I just sent you another pull request which fixes midiout
on ALSA:<br>
<br>
<a moz-do-not-send="true"
href="https://github.com/pd-l2ork/pd/pull/36">https://github.com/pd-l2ork/pd/pull/36</a><br>
<br>
It's a really long-standing bug, and has been in every
Pd version in Linux as long as I can remember. The
previous implementation of sys_alsa_putmidibyte() in
s_midi_alsa.c is broken -- it just spits out malformed
1-byte "sysex" messages for each byte that goes into
midiout. You can see that if you run the
cyclone/seq-help.pd patch and hook it up to kmidimon or
qmidiroute to watch the MIDI output. My new
implementation does the necessary buffering and parsing
using the appropriate ALSA routines to emit proper MIDI
messages. It also works fine with system realtime and
exclusive messages.<br>
<br>
</div>
<div>I don't foresee any adverse effects from this
changeset, as it just fixes some functionality which
wasn't working at all previously. <br>
</div>
<div><br>
</div>
Is there some kind soul who would take care of submitting
this upstream so that vanilla Pd gets fixed as well? I
don't have the time to do that myself right now.<br>
<br>
</div>
Talking about long-standing MIDI bugs in Pd, there's another
one which I haven't fixed yet although it's probably easy to
do. The bendin object produces an unsigned value range of 0
thru 16383, while the bendout object expects a signed range
of -8192 thru +8191. Which means that you have to translate
the values when routing pitch bends from MIDI input to MIDI
output. Again, you can observe that with Kmidimon on Linux
or MidiMonitor on the Mac, and it affects all different Pd
flavors (vanilla, extended, l2ork). I recall that I talked
to Miller about this a few years ago, but then forgot to
follow up on it. Am I the only one to notice this? I can't
believe that. :)<br>
<br>
</div>
Anyway, I'm not sure whether it actually makes sense to still
fix the bendin/bendout issue at this point, as there's
probably a gazillion patches out there which assume this
behavior. Maybe there's even a rationale behind it?<br>
<br>
</div>
Opinions?<br clear="all">
<div>
<div>
<div>
<div>
<div>
<div><br>
</div>
<div>Albert<br>
<br>
</div>
<div>-- <br>
<div class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">Dr. Albert Gr"af<br>
Computer Music Research Group, JGU Mainz,
Germany<br>
Email: <a moz-do-not-send="true"
href="mailto:aggraef@gmail.com"
target="_blank">aggraef@gmail.com</a><br>
WWW: <a moz-do-not-send="true"
href="https://plus.google.com/+AlbertGraef"
target="_blank">https://plus.google.com/+AlbertGraef</a></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
L2Ork-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:L2Ork-dev@disis.music.vt.edu">L2Ork-dev@disis.music.vt.edu</a>
<a class="moz-txt-link-freetext" href="http://disis.music.vt.edu/listinfo/l2ork-dev">http://disis.music.vt.edu/listinfo/l2ork-dev</a></pre>
</blockquote>
<br>
</body>
</html>