[L2Ork-dev] Bunch of commits and a merge request from my branch

[Ivica Ico Bukvic]

Also, please note 1 critical bug, a major crasher dealing with the 
pasting buffer into the patch and trying to interpret it as a patch (or 
code snippet). The same also does nothing even when having a correct 
code snippet pasted (1.x does its best to interpret whatever is 
workable, e.g. incomplete connections due to missing objects are 
reported as errors, while pasting the entire patch into a blank window 
will also resize the window and adjust all its parameters).

  *
    Selecting any object and pasting bogus stuff (e.g. random text)
    crashes Purr-Data
    <https://git.purrdata.net/jwilkes/purr-data/-/issues/638>
    #638· opened6 hours agobyIvica Bukvic
    <https://git.purrdata.net/ico>critical
    <https://git.purrdata.net/jwilkes/purr-data/-/issues?label_name%5B%5D=critical>
      o 2 <https://git.purrdata.net/jwilkes/purr-data/-/issues/638#notes>
    updated6 hours ago


Best,

Ico

On 6/5/2020 6:12 PM, Ivica Ico Bukvic wrote:
> Here's the breakdown of the new improvements (granted, some of them 
> are purely aesthetic but in my opinion nonetheless important, 
> particularly when considering new users):
>
> commit bb9a14a56d6b8aeb9432a7fc924dccee972d96c7 (HEAD -> master, 
> origin/master, origin/HEAD)
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 18:00:48 2020 -0400
>
>     Introduced a way to deal with non-standard GUIs inside externals 
> (e.g. those that don't stay true to the xy being the top-left origin, 
> such as the ggee/image), so that they can introduce an appropriate 
> offset during autopatching to ensure they are properly positioned 
> below the object above them. You can now use glob_autopatch_connectme 
> to detect inside the external whether you are being autopatched (add 
> it to the external by using extern glob_autopatch_connectme)
>
> commit e3d0a4bc67f1bd6231c79d2591f9ce332e571502
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:33:34 2020 -0400
>
>     Further visual tweaks for the objects that failed to create
>
> commit 3eb55827f1e8ca733141d0e9f4755deedd68b7c2
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:07:18 2020 -0400
>
>     Visual improvements to the default theme to match 1.x branch 
> including consistent highlight coloring and improvements to the nlet 
> highlighting.
>
> commit 884b8d51e0a0b375f3461509f214e222e335a43e
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:06:36 2020 -0400
>
>     Improved ability to pinpoint nlets
>
> commit efd894b15069096faaaea3e7eaa01463784e95e1
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:05:50 2020 -0400
>
>     Typo fix
>
> commit 7a177682a2936360af9e4e47b8cbaf7b1f3023dc
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:03:36 2020 -0400
>
>     Finished adding pd-l2ork 1.x features to the ggee/image. Still 
> need to update K12 abstractions since they are for some reason off by 
> 1 pixel to the right and down from what they used to be in 1.x. Best 
> way to fix this is likely by fixing the abstractions. Another thing to 
> consider is autopatching of an image currently looks weird and does 
> not respect the autopatching spacing...
>
> commit ebb6f0eb4bb8d925c1d2776174e80c40b413fc3f
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 17:01:12 2020 -0400
>
>     Improved coloring of cords while making connections
>
> commit addc7be7561b804db1936f2523232a5c47804ebc
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 12:01:58 2020 -0400
>
>     Removed more unnecessary legacy code from the ggee/image
>
> commit 5a6073a6fdbea58424ca0e477074c66b4bf486fc
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 10:59:15 2020 -0400
>
>     Fixed ggee/image offset that makes it incompatible with the 1.x 
> implementation. (this one was overwritten later by a commit above)
>
> commit d3931d646ca4e2a5168bf47afe13427f22f6b732
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 10:45:25 2020 -0400
>
>     Fixes ggee image having selection box appear even when it is 
> inside a GOP (test with any K12 abstractions from the 1.x branch), and 
> removes unnecessary legacy calls and commented out obsolete code.
>
> commit 0084a68d9a10350f6b19b2e85f0ff7582257ac07
> Author: Ivica Ico Bukvic <ico at vt.edu>
> Date:   Fri Jun 5 00:00:32 2020 -0400
>
>     Fixed issue #606. Given the changes Jonathan introduced to the 
> scalars, the redrawing as part of the graph_vis 1 call needs to be 
> tested. Prior to this commit, it appears there was only deletion of 
> g_objs but not their redrawing. (this one has a merge request on the 
> main branch)
>
> I think the project would benefit from having one central branch that 
> is co-owned by Jonathan, Albert, and I (assuming that is even possible 
> inside git), with each one of us maintaining our own branches. That is 
> assuming Jonathan feels comfortable with such an arrangement.
>
> Best,
>
> Ico
>
-- 
Ivica Ico Bukvic, D.M.A.
Director, Creativity + Innovation
Institute for Creativity, Arts, and Technology

Virginia Tech
Creative Technologies in Music
School of Performing Arts – 0141
Blacksburg, VA 24061
(540) 231-6139
ico at vt.edu

www.icat.vt.edu
www.performingarts.vt.edu
l2ork.icat.vt.edu
ico.bukvic.net

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20200605/a5db2def/attachment-0001.html>