[L2Ork-dev] GOP redraw bug

[Ivica Ico Bukvic]

Submitted a merge request with a fix. It appears this was a regression 
from a fix that Jonathan may have introduced in respect to scalars being 
unvis-ed. I added a hypothetical corresponding vis for scalars only 
inside the graph_vis call that needs to be tested before the branch is 
merged.

Best,

Ico

On 6/4/2020 11:12 PM, Ivica Ico Bukvic wrote:
> So, I tracked this problem down to the g_graph.c line 960 where 
> graph_vis 0 deletes all glist objects inside gop regardless whether 
> they are scalars or not and when graph_vis 1 is called it does not do 
> anything to the subwindow but only its representation on the parent 
> window. When commented out, this fixes the problem but likely breaks 
> the scalars. So, now I need to track if there is a way for glist to 
> report whether it has any scalars and if so, to delete and redraw them 
> as part of the graph_vis. This is all kind of hacky since this will 
> result in 2 redraw cycles for each undo. Perhaps only catching scalars 
> may be a way to do this...
>
> To reproduce the bug, use the attached patch, delete some objects in 
> the subpatch, then undo and they will all disappear, leaving only 
> patch cords and the gop rectangle.
>
> Best,
>
> Ico
>
-- 
Ivica Ico Bukvic, D.M.A.
Director, Creativity + Innovation
Institute for Creativity, Arts, and Technology

Virginia Tech
Creative Technologies in Music
School of Performing Arts – 0141
Blacksburg, VA 24061
(540) 231-6139
ico at vt.edu

www.icat.vt.edu
www.performingarts.vt.edu
l2ork.icat.vt.edu
ico.bukvic.net