[L2Ork-dev] Purr Data 2.13.0 released - Weird Patch Window issues

Albert Graef aggraef at gmail.com
Tue Aug 11 11:29:03 EDT 2020


Nope, doesn't fix it for me, unfortunately. :( I posted the details in your
merge request.

Albert

On Mon, Aug 10, 2020 at 8:53 PM Ivica Bukvic <ico at vt.edu> wrote:

> All,
>
> I just submitted a fix for both the margin-less scrollbars and the optimal
> zoom bug. It appears this function was left from the 0.46+ improvements and
> will need to be updated as per provided comments once we migrate to 0.46+.
> You will find the change inside the pdgui.js' canvas_check_geometry.
>
> Please test and let me know if this fixes it. BTW, on Windows, when one
> saves a maximized window, it still does not reopen maximized (unlike Linux)
> but ends up being centered with a couple of pixels of margins on all sides
> despite the fact that the saved file contains accurate window size (when
> compared to what the dev tools are reporting). I suspect this is a
> windows-only issue.
>
> For the fixes please see:
>
> https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/485
>
> Hope this helps.
>
> Best,
>
> Ico
>
> --
> Ivica Ico Bukvic, D.M.A.
> Director, Creativity + Innovation
> Director, Human-Centered Design iPhD
> Institute for Creativity, Arts, and Technology
>
> Virginia Tech
> Creative Technologies in Music
> School of Performing Arts – 0141
> Blacksburg, VA 24061
> (540) 231-6139
> ico at vt.edu
>
> ci.icat.vt.eduhcd.icat.vt.eduwww.icat.vt.edu
> www.performingarts.vt.edu
> l2ork.icat.vt.edu
> ico.bukvic.net
>
>
>
> On Tue, Aug 4, 2020 at 8:41 AM Linux ROUEN Normandie <linux.rouen at free.fr>
> wrote:
>
>> Hello Albert,
>> Thanks for your additional tests.
>>
>> As suggested, I will open a Ticket on the Bug tracker for GNU/Linux and
>> Windows.
>> It needs to be also tested by someone on macOS.
>> Best, Joseph
>> - - - - - - - - - - - - - - - - - - - -
>> Le 04/08/2020 à 07:44, Albert Graef a écrit :
>>
>> Well, there definitely seems to be a regression in 2.12, in that the
>> maximized status of a patch window isn't properly restored. That is, if I
>> open a patch, maximize it, then save the patch, relaunch purr-data and
>> reopen the patch, then:
>>
>> - the patch window is maximized in 2.11
>> - the patch window is *not* maximized in 2.12 and 2.13, it's merely an
>> unmaximized window which covers the entire display
>>
>> The window size getting smaller only happens if you save the window in
>> zoomed state, with the "save/load zoom level with patch" option enabled in
>> the GUI prefs. Also, the amount by which the window is too small depends on
>> the actual zoom level of the patch, with higher zoom levels it gets
>> smaller. According to my tests, this is in both 2.12 and 2.13 as well. In
>> 2.11 the size of zoomed windows is properly restored. So it seems that both
>> regressions are related to the GUI changes you did in the 2.12 release.
>>
>> I can provide more data, screenies, and test patches if needed, but I'd
>> prefer having a proper ticket opened at
>> https://git.purrdata.net/jwilkes/purr-data/-/issues for this issue, so
>> that we have all this properly documented. Joseph, can you please take care
>> of that? Thanks.
>>
>> Albert
>>
>> = = = = = = = = = =
>> On Mon, Aug 3, 2020 at 10:07 PM Ivica Bukvic <ico at vt.edu> wrote:
>>
>>> Also, Albert and Jonathan, are you experiencing this same problem on
>>> your Linux test machine? I can reproduce the first step where the window is
>>> not maximized anymore after saving, closing, and reloading. It, however,
>>> does not keep getting smaller.
>>>
>>> Best,
>>>
>>> Ico
>>>
>>> --
>>> Ivica Ico Bukvic, D.M.A.
>>> Director, Creativity + Innovation
>>> Director, Human-Centered Design iPhD
>>> Institute for Creativity, Arts, and Technology
>>>
>>> Virginia Tech
>>> Creative Technologies in Music
>>> School of Performing Arts – 0141
>>> Blacksburg, VA 24061
>>> (540) 231-6139ico at vt.edu
>>> ci.icat.vt.eduhcd.icat.vt.eduwww.icat.vt.eduwww.performingarts.vt.edul2ork.icat.vt.eduico.bukvic.net
>>>
>>>
>>>
>>> On Mon, Aug 3, 2020 at 4:04 PM Ivica Bukvic <ico at vt.edu> wrote:
>>>
>>>> Hmm, this may be my doing. I slightly downsized the svg canvas with
>>>> what I thought would be a fix to Albert's bug report regarding the
>>>> scrollable window without the scrollbars. Perhaps this is not the right way
>>>> to fix this. Lemme investigate further. Is the window getting smaller both
>>>> width and height-wise? My fix was only addressing the height and did not
>>>> touch the width.
>>>>
>>>> --
>>>> Ivica Ico Bukvic, D.M.A.
>>>> Director, Creativity + Innovation
>>>> Director, Human-Centered Design iPhD
>>>> Institute for Creativity, Arts, and Technology
>>>>
>>>> Virginia Tech
>>>> Creative Technologies in Music
>>>> School of Performing Arts – 0141
>>>> Blacksburg, VA 24061
>>>> (540) 231-6139ico at vt.edu
>>>> ci.icat.vt.eduhcd.icat.vt.eduwww.icat.vt.eduwww.performingarts.vt.edul2ork.icat.vt.eduico.bukvic.net
>>>>
>>>>
>>>>
>>>> On Mon, Aug 3, 2020 at 12:57 PM Linux Rouen <linux.rouen at free.fr>
>>>> wrote:
>>>>
>>>>> Hello All,
>>>>>
>>>>> Thanks to the developers and all involved for releasing Purr Data
>>>>> 2.13.0. It's looking promising. I'm using the OBS channel.
>>>>>
>>>>> I just made a quick test under Manjaro 20.0.3 KDE Plasma (based on
>>>>> Arch
>>>>> Linux) and there are some weird issues with the way of how the patch
>>>>> windows are now handled.
>>>>> This was not the case with the original V.2.12.0 release under Manjaro.
>>>>>
>>>>> The MAIN Patch Window Size (not the sub-patches if any) has some kind
>>>>> of
>>>>> dysfunction, even if in Prefs / GUI the Zoom level is clicked to be
>>>>> saved/loaded with the patch.
>>>>> When I mean MAIN patch, I mean the patch at the higher level. If there
>>>>> is only one patch, this patch as the same bad behavior than the main
>>>>> patch with sub-patches.
>>>>>
>>>>> So, You save your patch with its window maximized (not full screen)
>>>>> and
>>>>> close it. Then at load:
>>>>> a)- the patch window is not opening at its saved size, it's smaller
>>>>> (windowed), but the zoom level is correct (patch content is now beyond
>>>>> window limits).
>>>>>
>>>>> You save again the patch without changing anything and close it. Then
>>>>> at
>>>>> load:
>>>>> b)- the patch window is not opening at its saved size, it's getting
>>>>> even
>>>>> smaller (still windowed) than in a), but the zoom level is correct.
>>>>> c)- each time you save it, close and open it, the patch window is
>>>>> getting step by step smaller and smaller.
>>>>>
>>>>> You maximize the window size, save it again and close it. Then at load:
>>>>> d)- you are back to a)-, and so on, until you get a window having the
>>>>> size of a postal stamp.
>>>>>
>>>>> You maximize the window size, you zoom out (-) its content, save the
>>>>> patch and close it. Then at load:
>>>>> e)- both the patch window size and the patch content zoom level are
>>>>> correct.
>>>>>
>>>>> You maximize the zoom of the patch content still with the patch window
>>>>> maximized, save and close it. Then at load:
>>>>> f)- you are back to a)-, and so on.
>>>>>
>>>>> With the patch being in c) state, you change the patch content to
>>>>> optimal zoom, you save and close it. Then at load:
>>>>> g)- the patch window size is bigger = a) state and the content zoom
>>>>> level is correct (but anymore optimized as the window got bigger), and
>>>>> so on.
>>>>>
>>>>> I didn't try all possible combinations.
>>>>>
>>>>> Best, Joseph
>>>>>
>>>>> = = = = = = = = = =
>>>>>
>>>>> Le 01/08/2020 à 23:15, Jonathan Wilkes a écrit :
>>>>> > Hi all,
>>>>> >
>>>>> > Purr Data 2.13.0 has just been released:
>>>>> >
>>>>> > https://git.purrdata.net/jwilkes/purr-data#downloads
>>>>> >
>>>>> > Changes:
>>>>> > * ported Vanilla's [inlet~ fwd] argument (reimplemented to avoid
>>>>> stack
>>>>> > allocation and various other problems) (Thanks to Guillem!)
>>>>> >
>>>>> > * scrollbar fix for optimal zoom (Thanks Ico!)
>>>>> >
>>>>> > *avoid null selectors in core where trivial to do so, gracefully
>>>>> > handle and annotate them when/if they happen. Also added an
>>>>> > experimental [debuginfo] object so we can output a message with a
>>>>> null
>>>>> > selector (and other methods in the future good for testing)
>>>>> >
>>>>> > * ported Vanilla patch for [pow~] handling negative samples in input
>>>>> >
>>>>> > * ported [savestate] from Vanilla
>>>>> >
>>>>> > * ported array, scalar "bang" methods
>>>>> >
>>>>> > * add base argument and inlet for [log]
>>>>> >
>>>>> > * add zcheckgetfn to m_pd.h for checking method signatures match
>>>>> > before doing an end run around typedmess. This is used for the
>>>>> > reimplementation of [inlet~ fwd]. (Thanks to Guillem for this)
>>>>> >
>>>>> > * port and re-implement Vanilla's "#ffffff" syntax for setting iemgui
>>>>> > colors. Additionally, support the "#fff" short syntax. We're not
>>>>> > currently saving the symbol colors in the Pd file format, yet. A
>>>>> > warning is printed about this since it means we're still storing the
>>>>> > lossy color format. A future version will save the symbol colors, but
>>>>> > we want to ship a few releases supporting the new syntax before
>>>>> making
>>>>> > this breaking file format change.
>>>>> >
>>>>> > * added "test-object" abstraction for doing more detailed testing of
>>>>> objects
>>>>> >
>>>>> > * fixed bug where the box width was wrong when editing certain
>>>>> objects
>>>>> > (thanks to Guillem)
>>>>> >
>>>>> > * port "seed" method for [noise~]
>>>>> >
>>>>> > * throttle canvas_motion (part 1 of 2 of getting rid of exponential
>>>>> > explosion when moving selections)
>>>>> >
>>>>> > * port [text] "sort" method
>>>>> >
>>>>> > * when clicking an error link, bring the relevant object into the
>>>>> > viewport and animate it to make it easy for the user to find
>>>>> >
>>>>> > * add "-alsaadd" flag with pulse device for pulse support (Thanks to
>>>>> Sam!)
>>>>> >
>>>>> > * fixed some alsa bugs
>>>>> >
>>>>> > * ported from Vanilla: preserve phase in [clone] after [all( message,
>>>>> > fixed a crasher
>>>>> >
>>>>> > * expand and improve the type hints for errors with edge case atoms
>>>>> > (null selectors, null symbols, "floatlike" symbol payloads, etc.)
>>>>> >
>>>>> > * improvements to french translations (Thanks Joseph!)
>>>>> >
>>>>> > * update pd-lua compatibility with Lua 5.4 (Thanks Albert!)
>>>>> >
>>>>> > * port multi-step undo from Vanilla (Thanks Guillem!)
>>>>> >
>>>>> > * initial touch support in GUI (Thanks Albert and spidercatnat!)
>>>>> >
>>>>> > * zoom viewport fix (Thanks Albert!)
>>>>> >
>>>>> > -Jonathan
>>>>> > _______________________________________________
>>>>> > L2Ork-dev mailing list
>>>>> > L2Ork-dev at disis.music.vt.edu
>>>>> > https://disis.music.vt.edu/listinfo/l2ork-dev
>>>>> _______________________________________________
>>>>> L2Ork-dev mailing list
>>>>> L2Ork-dev at disis.music.vt.edu
>>>>> https://disis.music.vt.edu/listinfo/l2ork-dev
>>>>
>>>>
>>
>> --
>> Dr. Albert Gr"af
>> Computer Music Research Group, JGU Mainz, Germany
>> Email: aggraef at gmail.com, web: https://agraef.github.io/
>>
>> _______________________________________________
>> L2Ork-dev mailing listL2Ork-dev at disis.music.vt.eduhttps://disis.music.vt.edu/listinfo/l2ork-dev
>>
>>
>> _______________________________________________
>> L2Ork-dev mailing list
>> L2Ork-dev at disis.music.vt.edu
>> https://disis.music.vt.edu/listinfo/l2ork-dev
>
>

-- 
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: aggraef at gmail.com, web: https://agraef.github.io/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20200811/334d0076/attachment-0001.html>


More information about the L2Ork-dev mailing list