[L2Ork-dev] updating cyclone

[Jonathan Wilkes]

Hello again,
I just pushed an update to my cyclone mirror. It's currently being tested in my 
CI build for the "update-cyclone" feature branch.  Once that succeeds you should be 
able to download one of the Purr Data binaries to test it.
One thing-- I noticed in scope_drawfg there's an invalid read of both xx/yy, so I 
went ahead and initialized them to 0.  Not sure if the algo is working the way 
the original author wants it to, however.  I simply got rid of the undefined behavior.

One more thing-- there were a number of trailing spaces and unnecessary commas (like 
ones appearing after conditional blocks or function blocks). I removed all the onces I found-- 
it's just a nuisance that eats up time.

Anyway, here's the commit to my mirror:https://git.purrdata.net/jwilkes/pd-cyclone/commit/b662fd817187dbaa3ff383fb333e2c127ee9c32e
And attaches is a patch if you want to apply it that way. It should apply cleanly to HEAD.
Do be sure to test it out on Vanilla to make sure I didn't break anything.

-Jonathan


      From: Alexandre Torres Porres <porres at gmail.com>
 To: Jonathan Wilkes <jancsika at yahoo.com> 
Cc: "l2ork-dev at disis.music.vt.edu" <l2ork-dev at disis.music.vt.edu>; "brbrofsvl at gmail.com" <brbrofsvl at gmail.com>; Derek Kwan <derek.x.kwan at gmail.com>
 Sent: Wednesday, April 19, 2017 4:56 PM
 Subject: Re: [L2Ork-dev] updating cyclone
   


2017-04-19 15:46 GMT-03:00 Jonathan Wilkes <jancsika at yahoo.com>:


The only remaining bug I noticed is that the makefile seems not to 
install the correct "Purr-data-specific" documentation.  Is it supposed 
to do that automatically?

not yet, I'm yet to try that

   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20170419/338d02f7/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-port-scope-to-Purr-Data.patch
Type: text/x-patch
Size: 101245 bytes
Desc: not available
URL: <http://disis.music.vt.edu/pipermail/l2ork-dev/attachments/20170419/338d02f7/attachment-0001.bin>